VirtualBox

5 年 前 建立

5 年 前 結束

#19148 closed defect (fixed)

SVN revision extracted from wrong variable in export_modules.sh

回報者: Jan Palus 負責人: Klaus Espenlaub
元件: other 版本: VirtualBox 6.1.0
關鍵字: 副本:
Guest type: other Host type: Linux

描述

It appears that VirtualBox 6.1 moved SVN revision information from VBOX_SVN_REV_FALLBACK variable to VBOX_SVN_REV_CONFIG_FALLBACK which was not reflected in export_modules.sh scripts (src/VBox/Additions/linux/export_modules.sh, src/VBox/HostDrivers/linux/export_modules.sh). Without SVN revision exported modules fail to compile. See attached patch.

附加檔案 (1)

svn_rev.patch (3.1 KB ) - 5 年 前, 由 Jan Palus 新增

下載所有附檔: .zip

更動歷史 (10)

5 年 前Jan Palus 編輯

附檔: 新增 svn_rev.patch

comment:1 5 年 前Frank Batschulat (Oracle) 編輯

Thanks, are you providing this patch under the MIT license? This needs to be explicitely stated in the bug/patch submittion.

For code contributions, please see:

https://www.alldomusa.eu.org/wiki/Contributor_information

How to submit your contributions

If you have developed a patch for VirtualBox which you think could be useful for others and fits within the product's architecture, then you should submit it for inclusion. As a first step, you should execute the Contributor's Agreement as described above, which is a very straightforward and risk-free process. Then you should submit your patch to the vbox-dev mailing list or to the Developers Corner forum (see the "Community" page) along with a description of what it does. In case you have not signed the CA, please explicitly state that you are licensing the patch under the MIT license. 

comment:2 5 年 前Jan Palus 編輯

I confirm that provided patch is under MIT license. Hopefully such statement is enough :).

回覆:  2 comment:3 5 年 前Frank Batschulat (Oracle) 編輯

Replying to jpalus:

I confirm that provided patch is under MIT license. Hopefully such statement is enough :).

Absolutely. thanks!

comment:4 5 年 前Frank Batschulat (Oracle) 編輯

狀態: newaccepted
負責人: 指定為 Frank Batschulat (Oracle)

comment:5 5 年 前Klaus Espenlaub 編輯

Thanks for spotting this remaining issue.

The patch isn't right, though, because it would just revive the old, broken SVN revision fallback handling. Config.kmk isn't guaranteed to be updated on a release (in fact in 99.9% of all cases it isn't any more). The correct handling is implemented in Config.kmk (setting VBOX_SVN_REV_FALLBACK, taking the maximum of VBOX_SVN_REV_CONFIG_FALLBACK and VBOX_SVN_REV_VERSION_FALLBACK), but that's not usable from these scripts.

If you need a quick solution, you can get a perfect fallback for releases (but not for the public svn repository) by going for VBOX_SVN_REV_VERSION_FALLBACK in Version.kmk.

comment:6 5 年 前Klaus Espenlaub 編輯

Hope that r82582 fixes this issue (also spotted that the script still cared about vboxpci which is disabled for 6.1.0). Didn't have time to test.

回覆:  6 comment:7 5 年 前Jan Palus 編輯

Thanks! I confirm that it works fine.

comment:8 5 年 前Frank Batschulat (Oracle) 編輯

狀態: acceptedassigned
負責人: Frank Batschulat (Oracle) 變更為 Klaus Espenlaub

comment:9 5 年 前Frank Batschulat (Oracle) 編輯

狀態: assignedclosed
處理結果: fixed
注意: 瀏覽 TracTickets 來幫助您使用待辦事項功能

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette