#19148 closed defect (fixed)
SVN revision extracted from wrong variable in export_modules.sh
回報者: | Jan Palus | 負責人: | Klaus Espenlaub |
---|---|---|---|
元件: | other | 版本: | VirtualBox 6.1.0 |
關鍵字: | 副本: | ||
Guest type: | other | Host type: | Linux |
描述
It appears that VirtualBox 6.1 moved SVN revision information from VBOX_SVN_REV_FALLBACK variable to VBOX_SVN_REV_CONFIG_FALLBACK which was not reflected in export_modules.sh scripts (src/VBox/Additions/linux/export_modules.sh, src/VBox/HostDrivers/linux/export_modules.sh). Without SVN revision exported modules fail to compile. See attached patch.
附加檔案 (1)
更動歷史 (10)
5 年 前 由 編輯
附檔: | 新增 svn_rev.patch |
---|
跟進: 3 comment:2 5 年 前 由 編輯
I confirm that provided patch is under MIT license. Hopefully such statement is enough :).
comment:3 5 年 前 由 編輯
Replying to jpalus:
I confirm that provided patch is under MIT license. Hopefully such statement is enough :).
Absolutely. thanks!
comment:5 5 年 前 由 編輯
Thanks for spotting this remaining issue.
The patch isn't right, though, because it would just revive the old, broken SVN revision fallback handling. Config.kmk isn't guaranteed to be updated on a release (in fact in 99.9% of all cases it isn't any more). The correct handling is implemented in Config.kmk (setting VBOX_SVN_REV_FALLBACK, taking the maximum of VBOX_SVN_REV_CONFIG_FALLBACK and VBOX_SVN_REV_VERSION_FALLBACK), but that's not usable from these scripts.
If you need a quick solution, you can get a perfect fallback for releases (but not for the public svn repository) by going for VBOX_SVN_REV_VERSION_FALLBACK in Version.kmk.
Thanks, are you providing this patch under the MIT license? This needs to be explicitely stated in the bug/patch submittion.
For code contributions, please see:
https://www.alldomusa.eu.org/wiki/Contributor_information